docs: render multiple @example blocks as tabbed code groups#3817
docs: render multiple @example blocks as tabbed code groups#3817xDivisionByZerox merged 9 commits intonextfrom
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3817 +/- ##
==========================================
- Coverage 98.90% 98.83% -0.07%
==========================================
Files 896 896
Lines 3100 3100
Branches 572 572
==========================================
- Hits 3066 3064 -2
- Misses 30 32 +2
Partials 4 4
🚀 New features to boost your workflow:
|
ST-DDT
left a comment
There was a problem hiding this comment.
Could you please add multi example test cases to our tests?
faker/test/scripts/apidocs/class.example.ts
Lines 27 to 33 in 04f21d3
faker/test/scripts/apidocs/method.example.ts
Lines 338 to 348 in 04f21d3
I hope that these will get picked up automatically, if you just add them to the file.
3eea927 to
abdf90b
Compare
149fccc to
72a37a4
Compare
xDivisionByZerox
left a comment
There was a problem hiding this comment.
Look cool. Thanks for that. 👍
|
We should follow up to see if there are any other example blocks which could benefit from being split like this. |
potential replacement for #3585
https://deploy-preview-3817.fakerjs.dev/api/faker.html